akka/akka-http

Replace ExecutionContextExecutor from scaladsl

Open

#2598 aperta il 16 lug 2019

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Scala (598 fork)batch import
1 - triagedhelp wantedt:routingtechnical-debt

Metriche repository

Star
 (1311 star)
Metriche merge PR
 (Merge medio 1g 10h) (2 PR mergiate in 30 g)

Descrizione

Especially, implicit ExecutionContextExecutor parameters should be replaced as they will never picked up (no one would provide such an implicit by default).

It seems, the ExecutionContext was changed to ExecutionContextExecutor in https://github.com/akka/akka/pull/19578 in an attempt to provide it to the javadsl.

I'd suggest:

  • We deprecate all methods that take an implicit ExecutionContextExecutor and replace them with ones that take an ExecutionContext
  • We need to decide how get an ExecutionContextExecutor out of an ExecutionContext where needed. We could either expect all instances to also be a ExecutionContextExecutor and WARN or fail otherwise, or we could wrap instances otherwise to provide the necessary Executor API for the javadsl side of things.
  • Not sure if we can do something about the very public API of scaladsl RequestContext.executionContext so maybe we need to keep it.

Guida contributor

Direzione di ricerca
Deprecare i metodi con implicito ExecutionContextExecutor, creare overload con ExecutionContext e avvolgere quest'ultimo in ExecutionContextExecutor dove necessario, garantendo la retrocompatibilità.
Tech stack
scala
Dominio
backend
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Attiva
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Git
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75