airbnb/react-sketchapp

Introduce `Page.Container` component

Open

Aperta il 30 mag 2018

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)TypeScript (14.970 star) (900 fork)batch import
enhancementgood first issuehelp wanted

Descrizione

Right now the Page component acts a flex container, allowing to render Artboard's and SymbolMaster's in either a column or a row.

I'd like however to have unlimited flexibility rendering Pages by composing Flex components. By having some sort of arbitrary Flex container, I could layout items on a Page in complex grids if necessary.

This would require us introducing a new Component that can be utilized to compute Yoga layout, but doesn't actually result in any backed rendering.

@mathieudutour - I know this goes against some of your comments in #291, but I'm not sure how else to achieve this.

note: it doesn't need to be called Flex.

Guida contributor

Tech stack
reacttypescript
Dominio
frontenddesign
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
ReactTypeScriptreact sketchapp API
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Examine the existing Page component in react sketchapp to understand its current flex container behavior. Review the discussion in issue #291 about layout flexibility, especially comments from @mathieudutour. The goal is to create a new container component (e.g., Flex) that computes Yoga layout without rendering anything. Look at the Yoga layout integration in the codebase, likely in the yoga layout package, and consider naming and API design.