airbnb/native-navigation

Provide an installation option without CocoaPods

Open

#54 aperta il 20 mar 2017

Vedi su GitHub
 (9 commenti) (4 reazioni) (0 assegnatari)Java (172 fork)github user discovery
help wantediOS

Metriche repository

Star
 (3121 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Dear authors,

Currently, there is only one way how you can add this project to iOS app (using CocoaPods). As a JavaScript / React Native developer, I'd like to be able to install this awesome library using react-native install or link it by using react-native link. Although it's not hard to do, the code won't work with a standard react-native init app due to the current way it imports React (using import React in Swift files).

I managed to make it work without these imports (by adding native-navigation library directly to the project), but I consider this way pretty hackish as I have to remove these imports by hand. I'd like to find a way how we can distribute a Cocoa pod using CocoaPods and npm module using the same codebase. The best thing I can think of is a pre-publish hook that cuts off imports before publishing (tmp dir -> s/import React//g -> publish files from tmp dir -> rm tmp dir).

What do you think?

Guida contributor