[Bug]: filtering by "notes > has tags" matches all transactions when no '#' character is specified

(1 commento) (0 reazioni) (0 assegnatari)JavaScript (603 fork)batch import

bughelp wanted

Metriche repository

Star: (7129 stelle)
Metriche merge PR: (Merge medio 4g 15h) (165 PR mergiate in 30 g)

Descrizione

What happened?

In the transaction list, if you want to filter transactions that have a specific tag, you choose "Filter > Notes > has tags" and then you're expected enter the tag name like "#foo". However, if you forget to specify the hash character and simply enter "foo" into the text entry box, it doesn't actually filtere anything and it simply shows all transactions.

How can we reproduce the issue?

go to transaction list. Assume that the transaction list has some transactions with the tag '#foo' in their transaction notes
click "filter > Notes > has tags"
type 'foo' in text entry
the list shows all unfiltered transactions

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Linux

Guida contributor

Direzione di ricerca: The bug is in the filter logic for 'has tags' in the transaction list. When a user types a tag without the '#' prefix, the filter fails. The fix likely involves automatically prepending '#' if missing, or validating input. Look for the filtering component, likely in the UI code under src/ or similar. Check the function handling the 'has tags' filter condition and adjust to handle the missing hash symbol.
Tech stack: javascriptreact
Dominio: frontend
Tipo issue: Bug
Difficoltà: 2
Tempo stimato: Meno di 1 ora
Stato attività: Nuova
Chiarezza: Chiara
Prerequisiti: JavaScriptReact
Adatta ai principianti: 80