abetlen/llama-cpp-python

suppress_stdout_stderr failing in notebooks

Chiusa

#872 aperta il 5 nov 2023

Vedi su GitHubGuida contributor
 (3 commenti) (0 reazioni) (0 assegnatari)Python (1441 fork)batch import
bughelp wanted

Metriche repository

Star
 (10.558 stelle)
Metriche merge PR
 (Merge medio 1g 5h) (68 PR mergiate in 30 g)

Descrizione

Expected Behavior

Loading a model with verbose=False should not print things.

Current Behavior

verbose=False has no effect in notebooks (I tested with VS Code notebooks, but I think it is ipykernel related)

Steps to Reproduce

Just load a model with verbose=False and observe output in a notebook environment.

How to fix

The patch given in the ipykernel issue below fixes the issue for me (but requires me to do my own override of stdout and stderr since the patch also causes suppress_stdout_stderr to crash as currently written). A real fix might involve integrating this into suppress_stdout_stderr directly.

https://github.com/ipython/ipykernel/issues/795

thanks!

Guida contributor

Direzione di ricerca
The issue is about `suppress stdout stderr` not working in notebook environments. The fix likely involves modifying the `suppress stdout stderr` function in the codebase, referencing the ipykernel issue (https://github.com/ipython/ipykernel/issues/795) for a patch. The function may live in a utility module; check the repository's source tree for relevant files. Integrate the patch to handle stdout/stderr redirection properly for ipykernel.
Tech stack
python
Dominio
backend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Nuova
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Abbastanza chiara
Prerequisiti
understanding of Python's io modulebasic knowledge of ipykernel
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60