Xabaril/AspNetCore.Diagnostics.HealthChecks

Redis Health Check

Open

Aperta il 30 mar 2021

Vedi su GitHub
 (3 commenti) (8 reazioni) (0 assegnatari)C# (3776 star) (737 fork)batch import
help wanted

Descrizione

What would you like to be added:

I have already registered a singleton IConnectionMultiplexer to my IoC container and I would like my health check to use that instead.

// Func<IServiceProvider, IConnectionMultiplexer>
.AddRedis(sp => sp.GetRequiredService<IConnectionMultiplexer>())

Why is this needed:

To use the same connection as the application

Guida contributor

Tech stack
csharpredis
Dominio
backendobservability
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
C#ASP.NET CoreRedis
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
The issue requests a new overload of the AddRedis extension method that accepts an IConnectionMultiplexer parameter. The change is likely in the HealthChecks.Redis project, specifically in the RedisHealthCheckBuilderExtensions class. A new method should be created that uses the provided connection multiplexer instead of creating a new one, following the existing pattern for dependency injection. Review the current AddRedis method signatures and the HealthCheckBuilderExtensions file to understand the expected implementation.