Xabaril/AspNetCore.Diagnostics.HealthChecks

Why do you pass HttpClientFactory as function?

Open

Aperta il 6 apr 2020

Vedi su GitHub
 (1 commento) (0 reazioni) (1 assegnatario)C# (3776 star) (737 fork)batch import
enhancementhelp wanted

Descrizione

Hi, Can someone please can explain to me why pass the HttpClientFactory as a function and not just as for instance?

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/d808dc0acdcd3f17c1156104f5eef369ccc293ac/src/HealthChecks.Consul/DependencyInjection/ConsulHealthCheckBuilderExtensions.cs#L44

Guida contributor

Tech stack
csharp
Dominio
backendapi
Tipo issue
documentation
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
C#ASP.NET CoreHttpClient
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
20
Direzione di ricerca
Examine the file ConsulHealthCheckBuilderExtensions.cs line 44 to understand the factory pattern used for HttpClientFactory. The existing comment in the issue likely explains the design rationale. Consider whether the pattern is used for delayed resolution of dependencies or to support different registration scenarios. There are no open PRs; the issue may be resolved but not closed.