WordPress/gutenberg

ESLint Plugin: @wordpress/dependency-group wrong grouping with fixer

Open

#17.050 aperta il 15 ago 2019

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (3893 fork)batch import
Good First IssueNeeds Dev[Priority] Low[Tool] ESLint plugin[Type] Enhancement

Metriche repository

Star
 (9607 star)
Metriche merge PR
 (Merge medio 12g 18h) (509 PR mergiate in 30 g)

Descrizione

Describe the bug I have this sample import statements:

import { format } from '@wordpress/date'
import { pickBy } from 'lodash'
import { PanelBody } from '@wordpress/components'

Running wp-scripts lint-js --fix on this groups together the dependencies, but doesn't rearrange the location so I end up with:

/**
 * WordPress dependencies
 */
import { format } from '@wordpress/date'

/**
 * External dependencies
 */
import { pickBy } from 'lodash'
import { PanelBody } from '@wordpress/components'

You'll have to manually move the @wordpress/* dependencies together.

Expected behavior The @wordpress/* / External / Internal dependencies would be sorted and grouped together.

Desktop (please complete the following information): Relevant part of my devDependencies:

"devDependencies": {
    "@wordpress/eslint-plugin": "^2.4.0",
    "eslint": "^6.1.0"
}

Guida contributor