StackStorm/st2

Predictive error message when config hasn't been loaded

Open

#3435 aperta il 25 mag 2017

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Python (740 fork)batch import
documentationfeaturegood first issue

Metriche repository

Star
 (5794 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

I've done support a few times now and one of the most common problems arises from the fact that someone has changed a pack config file but haven't reloaded it.

The error message that usually pops up is a KeyError, since the action or sensor will likely be looking up some key in the config that may not exist in the config stored in the database. However, for some packs, where the default configuration is provided with some dummy values, this may not always be the case

It may be worth putting some thought into how we can detect whether or not the configuration has been reloaded recently, and provide something useful to the user that indicates this is what they should do. At the very least, we should catch "common" exceptions like KeyError and provide this additional context before re-raising.

Guida contributor