SigNoz/signoz

[authn] handle invalid invitation token gracefully in signup page

Chiusa

#7011 aperta il 3 feb 2025

Vedi su GitHubGuida contributor
 (7 commenti) (0 reazioni) (2 assegnatari)TypeScript (976 fork)batch import
authenticationfrontendgood first issue

Metriche repository

Star
 (16.037 stelle)
Metriche merge PR
 (Merge medio 5g 22h) (224 PR mergiate in 30 g)

Descrizione

Bug Description

In case of invalid/used/expired invitation tokens, we still show the Sign Up page which is an invalid state to be at.

As the outcome after filling the sign up page would be this:

Expected Behaviour

Ideally, we should redirect the users to the Login Page where we should display the error message: "invalid/used/expired invitation token. Please contact your admin."

How to Reproduce

  1. Create a user invitation
  2. Use the invitation once, log out, and use the same link again
  3. Or update the invitation token from the URL to something else

Version Information

  • Signoz version: latest
  • Browser version: NA
  • Your OS and version: NA
  • Your CPU Architecture(ARM/Intel): NA

Additional Context

NA

Guida contributor

Direzione di ricerca
Investigate the signup page component (likely in frontend/.../Signup.tsx) and the authentication service that handles invitation tokens. Review the existing comments on this issue for any proposed solutions. Consider adding a redirect to the login page with an appropriate error message when the token is invalid.
Tech stack
typescriptreact
Dominio
frontendauthentication
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Mezza giornata
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Bloccata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
React knowledgeAuth flow understandingFrontend routing
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
55