SigNoz/signoz

Feat(FE): Global Time Visibility as per route

Open

Aperta il 25 ott 2022

Vedi su GitHub
 (6 commenti) (0 reazioni) (1 assegnatario)TypeScript (16.037 star) (976 fork)batch import
good first issuehacktoberfest

Descrizione

Is your feature request related to a problem?

Please describe. Right now to show the global header we are using routesToSkip , need to refactor the logic to display according to the route where this component is required

eg:

routes = ['/services','/service/:id','/trace','/logs','/dashboard/:dashboardId','/exceptions','/service-map']

Describe the solution you'd like

we can keep an array of routes in which the header needs to disable

Thank you for your feature request – we love each and every one!

Guida contributor

Tech stack
typescriptreact
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
ReactTypeScriptBasic routing concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
Examine the current implementation in `frontend/src/container/TopNav/index.tsx` that uses `routesToSkip`. Identify the routes where the global header should be shown instead of hidden. Refactor by switching to a whitelist approach, and test the changes with the mentioned routes like `/services`, `/trace`, etc.