Semantic-Org/Semantic-UI-React

bug: [Popup] doesn't take into account popper's attributes, only styles

Open

Aperta il 24 lug 2024

Vedi su GitHub
 (6 commenti) (0 reazioni) (0 assegnatari)JavaScript (13.136 star) (4065 fork)batch import
buggood first issue

Descrizione

Bug Report

state.attributes.popper aren't applied to the popup wrapper div, only state.styles.popper are.

Steps

  1. Use Popup component with default props and modifiers (which include hide by default) and on="click".
  2. Open the popup by clicking the trigger.
  3. Scroll the trigger out of the viewport.

Expected Result

The popup wrapper div gets the attributes data-popper-escaped and data-popper-reference-hidden from the default hide modifier.

Actual Result

No attributes are added to the div.

Version

2.1.5

Guida contributor

Tech stack
reactjavascript
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
ReactPopper.js
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
Look at the Popup component in Semantic UI React, likely in src/modules/Popup/Popup.js or similar. The popup wrapper div currently applies state.styles.popper but not state.attributes.popper. The fix involves merging attributes from state.attributes.popper into the wrapper div's props. Ensure that attributes like data popper escaped and data popper reference hidden from the hide modifier are passed to the div. Check the Popper.js documentation for how attributes are handled and verify that the default hide modifier is being used. The issue is isolated to the Popup component's rendering logic.