Semantic-Org/Semantic-UI-React

StrictTextAreaProps has a type that includes number and undefined for the "value" field

Open

Aperta il 20 feb 2024

Vedi su GitHub
 (6 commenti) (0 reazioni) (0 assegnatari)JavaScript (13.136 star) (4065 fork)batch import
buggood first issue

Descrizione

Bug Report

Steps

<Form.TextArea onChange={(_: unknown, data: TextAreaProps) => {
  const s: string =  data.value;
}}/>

Expected Result

No TypeScript errors.

Actual Result

Type 'string | number | undefined' is not assignable to type 'string'.

Version

2.1.5

Testcase

https://codesandbox.io/p/sandbox/semantic-ui-react-forked-5tf5yh

Notes

It doesn't appear to be possible to actually set the value of the textarea to a number or undefined, so it's not clear why I'd have to cast, and it's very inconvenient to cast undefined to a String since String(undefined) is "undefined" instead of "".

Guida contributor

Tech stack
reacttypescript
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
TypeScript basicsReact components
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
Look at the type definition for StrictTextAreaProps in the Form.TextArea component source. The issue is that 'value' is typed as string | number | undefined, but it should only be string. Find the type file (likely in src/components/Form/FormTextArea.d.ts) and update the type to be string. Ensure that changing this does not break other uses of the same prop in other components.