Semantic-Org/Semantic-UI-React

Dropdown scroll position going top when adding options

Open

Aperta il 26 lug 2019

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (13.136 star) (4065 fork)batch import
help wantedneeds engineering

Descrizione

Hello,

I did search in the 30+ issues opened but did not see anything similar. Here is the bug I've encountered :

Bug Report

When modifying options of a Dropdown while you are scrolling inside of it, the scroll position going full top.

Expected Result

Scroll staying on actual position

Actual Result

Scroll reseting to top

Version

SUIR@0.87.3

Testcase

In this Testcase, I simulated addition of elements when clicking on a button. FYI, in my reality case, I am doing an infinite scroll, which is adding elements when needed.

https://codesandbox.io/s/semantic-ui-react-example-1xvv7?fontsize=14

Guida contributor

Tech stack
javascriptreact
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
ReactSemantic UI React basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
The issue reports that the Dropdown component's scroll position resets to top when its options are modified while scrolling. The testcase in the issue shows adding options via a button. The likely cause is that the component re renders and resets the scroll position. Investigate the Dropdown component source code, typically in `src/modules/Dropdown/Dropdown.js`. Look for how the scroll position is managed, possibly via a ref or state. The fix may involve preserving the scroll position before re render and restoring it after. Check if there are any lifecycle methods or hooks that handle this. Since the issue is old and unassigned, no linked PRs or comments exist.