Semantic-Org/Semantic-UI-React

Search: ability to pass Image props in SearchResult

Open

#3619 aperta il 24 mag 2019

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (4065 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (13.136 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Feature Request

Problem description

I wanted to use circular images in <Search> results. However, the image prop only accepts a string according to the documentation, not a props object.

I tried passing an object anyway { circular : true, src : 'https://...' } and it renders the image successfully. However, the image isn't circular, despite the fact that the circular class is correctly applied. The border-radius seems to be overridden by a selector with higher precedence. I then tried using a custom render function and had the same result.

Since the documentation doesn't indicate that props objects are supported here, maybe this is expected? But it's kind of surprising nonetheless.

Proposed solution

Officially support props object for image and fix any relevant CSS precedence issues.

MVP

https://codesandbox.io/s/semantic-ui-react-xce2z

Guida contributor