Semantic-Org/Semantic-UI-React

Search: ability to pass Image props in SearchResult

Open

Aperta il 24 mag 2019

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (13.136 star) (4065 fork)batch import
enhancementhelp wanted

Descrizione

Feature Request

Problem description

I wanted to use circular images in <Search> results. However, the image prop only accepts a string according to the documentation, not a props object.

I tried passing an object anyway { circular : true, src : 'https://...' } and it renders the image successfully. However, the image isn't circular, despite the fact that the circular class is correctly applied. The border-radius seems to be overridden by a selector with higher precedence. I then tried using a custom render function and had the same result.

Since the documentation doesn't indicate that props objects are supported here, maybe this is expected? But it's kind of surprising nonetheless.

Proposed solution

Officially support props object for image and fix any relevant CSS precedence issues.

MVP

https://codesandbox.io/s/semantic-ui-react-xce2z

Guida contributor

Tech stack
javascriptreact
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Familiarity with React componentsUnderstanding of CSS specificity
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Examine the Search component in the Semantic UI React repository, particularly how the `image` prop is handled in SearchResult. Check the Image component's prop types and styling. Replicate the CSS precedence issue shown in the provided CodeSandbox. Potential fix involves modifying the SearchResult to accept an object for `image` and ensuring the `circular` class is not overridden by other styles. Look at existing PRs or comments for guidance.