SFTtech/openage

Allow easy usage of different compiler versions in the buildsystem

Chiusa

#1253 aperta il 4 mag 2020

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Python (1135 fork)batch import
area: buildsystemgood first issueimprovement

Metriche repository

Star
 (12.130 stelle)
Metriche merge PR
 (Merge medio 9g 23h) (1 PR mergiata in 30 g)

Descrizione

Right now we can not easily set a compile and a version within our configure script. #1250 did a small fix for clang-9 and clang-10 because we needed that for the CI. But it would be nice to create some parser that "respects the versions making it easier to test for multiple compiler versions" (@TheJJ ).

Regarding:

This should be just a small fix, we should probably implement something that splits compiler into compiler-name and compiler-version => if it's clang and then append the version to clang++.

Originally posted by @simonsan in https://github.com/SFTtech/openage/pull/1250

And yes, the compiler-name-and-version parser would be the real fix. But, if we implement it, the version should actually be respected, since that way you may test multiple compiler versions easily.

Originally posted by @TheJJ in https://github.com/SFTtech/openage/pull/1250

Guida contributor

Direzione di ricerca
Examine the configure script (likely in the buildsystem directory) and the changes from PR #1250 to understand how compiler versions are currently handled. Implement a parser that splits the compiler string into name and version, then uses the version to select the appropriate compiler binary (e.g., clang++ 10). Ensure the parser respects the version to allow testing multiple compiler versions. Review the discussion in the linked PR for further context.
Tech stack
pythoncpp
Dominio
build systemdeveloper experience
Tipo issue
Funzionalità
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Mezza giornata
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Python scriptingBuild system knowledgeC++ compiler basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70