RicoSuter/NJsonSchema

When using #ref the CSharp CodeGen does not include appropriate data annotiations

Open

#957 aperta il 23 apr 2019

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)C# (550 fork)github user discovery
help wantedtype: enhancement

Metriche repository

Star
 (1578 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

I recently added some $refs to my schema and noticed that the generator dropped some of the annotation. Previous schema:

{
    "$schema": "http://json-schema.org/draft-04/schema#",
    "type": "object",
    "additionalProperties": false,
    "properties": {
        "id": {
           "type": "string",
           "pattern": "^[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$"
        }
    }
}

New schema:

{
    "$schema": "http://json-schema.org/draft-04/schema#",
    "type": "object",
    "additionalProperties": false,
    "properties": {
        "id": {
           "$ref": "#/definitions/guid"
        }
    },
    "definitions": {
        "guid": {
            "type": "string",
            "pattern": "^[0-9a-fA-F]{8}-([0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12}$"
        }
    }
}

The generated code no longer has the DataAnnotiation for regular expressions. It also removes length restrictions, etc.

Guida contributor