PostHog/posthog

Add pageleave warning to Feature Flags edit page if changes are not committed

Chiusa

#5187 aperta il 17 lug 2021

Vedi su GitHubGuida contributor
 (19 commenti) (0 reazioni) (1 assegnatario)Python (988 fork)batch import
enhancementfeature/feature-flagsgood first issueteam/feature-flags

Metriche repository

Star
 (16.704 stelle)
Metriche merge PR
 (Merge medio 17h 29m) (995 PR mergiate in 30 g)

Descrizione

Is your feature request related to a problem?

It is way too easy to navigate away from the Feature Flags edit page without pressing "Save", losing all changes. I have done it probably a dozen times.

Describe the solution you'd like

Longer term, any changes to filter criteria should auto-save. But because this will probably require extra testing and implementation time, for now a browser message like "Are you sure? Changes may not be saved" would suffice.

Describe alternatives you've considered

Additional context

Thank you for your feature request – we love each and every one!

Guida contributor

Direzione di ricerca
Look at the Feature Flags edit page component (likely in frontend/src/scenes/FeatureFlags/FeatureFlagsEdit.tsx). Add a beforeunload event listener that triggers when there are unsaved changes. Ensure the warning only shows when form is dirty. Review existing patterns for unsaved changes warnings in other edit pages in the codebase for consistency.
Tech stack
typescriptreactcss
Dominio
frontend
Tipo issue
Funzionalità
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
ReactTypeScriptPostHog frontend conventionsbrowser event handling
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75