We ought to consolidate code in Wrangler for computing a URL given an absoluteURL and a RID · Picolab/pico-engine

(1 commento) (0 reazioni) (0 assegnatari)TypeScript (10 fork)auto 404

enhancementgood first issue

Metriche repository

Star: (51 stelle)
Metriche merge PR: (Metriche PR in attesa)

Descrizione

To install a ruleset, you have two options:

Provide the absolute (full) URL of where the source code is located, or
Provide an absolute URL of an already-installed ruleset (usually the one that is evaluating) and the RID of another ruleset whose source code is located in the same folder (see RFC-3986, section 4.2)

As Wrangler is written now, there are two places where we compute an absolute URL from a given URL and a RID. These are:

The rule install_ruleset_relatively here, which I view as the "official" place
The rule initialize_child_after_creation here, which should be changed in lines 410-411 to raise the same event but with different attributes

Guida contributor

Direzione di ricerca: Identifica le due posizioni del codice che calcolano l'URL assoluto da un URL e un RID, e consolidale in un'unica funzione riutilizzabile.
Tech stack: typescript
Dominio: backend
Tipo issue: Refactoring
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: GitKRL
Adatta ai principianti: 40