OpenFeign/feign

MockClient decode url before matching

Open

Aperta il 13 set 2018

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Java (9070 star) (1911 fork)batch import
bughelp wanted

Descrizione

When executing a request, inside this method public synchronized Response execute(Request request, Request.Options options) requestKey is created based on the request. However, it decodes the url so that we cannot test the actual url will be sent by the client.

For example, if my request url contains %2F like /a%2Fb, the requestKey only contains /. When I expect the final url which is sent to server should be /a%2Fb. What I get from mockClient is a url /a/b

Guida contributor

Tech stack
java
Dominio
testingapi
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaHTTPUnit testingFeign basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
75
Direzione di ricerca
Examine the execute method in MockClient.java to understand how requestKey is generated from the request URL. The issue indicates that URL decoding occurs, so the fix is to either not decode the URL or to preserve the original encoded URL for matching. Review the codebase for any existing URL normalization logic. No linked PRs or comments are available.