OpenFeign/feign

Feign observation span is not put in "scope" - loggers do not see current spanId

Open

Aperta il 5 mag 2024

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Java (9070 star) (1911 fork)batch import
bughelp wanted

Descrizione

Despite new observation is started around feign call, MDC still contains "parent" spanId.

Code to reproduce:

https://github.com/norbson/feign-tracing-issue

run and call http://localhost:8080/test

Result: Screenshot from 2024-05-05 18-04-03

Guida contributor

Tech stack
javaspring
Dominio
backendapiobservability
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaSpringMicrometer Observation
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
50
Direzione di ricerca
The issue is that the Feign observation span is not placed in scope, causing MDC to retain the parent spanId. Investigate the Feign observation instrumentation, likely in the `feign micrometer` module. Check if the observation is being opened and closed correctly, and ensure that the span is set as the current span in the tracing context. Look at the Micrometer Observation API's `Observation.Scope` usage and compare with similar tracing integrations. The reproduction repository is at https://github.com/norbson/feign tracing issue.