OpenFeign/feign

Enhance SoapDecoder by using Content Type from Response as Mime Type

Open

Aperta il 25 ago 2022

Vedi su GitHub
 (2 commenti) (1 reazione) (0 assegnatari)Java (9070 star) (1911 fork)batch import
help wantedproposal

Descrizione

By sending a soap request to an external service, i've found that the response of that soap call contains the Content-Type "multipart/related; type="application/xop+xml"; boundary=...".

The result is that the soap Message unmarshalling fails with some error "Unexpected content...". I've fixed that by creating a copy of SoapDecoder and propagate the Content-Type of the response to the MessageFactory. After that the Soap Envelope was unmarshalled as expected.

The relevant part that i've changed is:

final MimeHeaders mimeHeaders = new MimeHeaders();
final String contentType = response.headers().get("Content-Type").stream().collect(Collectors.joining(";"));
mimeHeaders.setHeader("Content-Type", contentType);
SOAPMessage message = MessageFactory.newInstance(soapProtocol)
                                    .createMessage(mimeHeaders, response.body().asInputStream());

Would be nice if it's possible to always use the Content-Type from the Response, but i don't know if there are any other pitfalls when doing that in general.

Kind regards,

Stefan

Guida contributor

Tech stack
java
Dominio
api
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
JavaSOAPFeign framework
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
The issue is to modify SoapDecoder to use the Content Type header from the HTTP response as the MIME type when creating the SOAPMessage. The user provided a code snippet showing the change in the decoder. Look at the SoapDecoder class in the Feign repository (likely `core/src/main/java/feign/soap/SoapDecoder.java`). The fix involves reading the 'Content Type' header from the response and setting it on the MimeHeaders before creating the message. Ensure that this change does not break other use cases where the content type might be missing or different. The maintainers may need to discuss the general applicability and potential pitfalls.