OpenFeign/feign

RetryableException requires Request

Open

Aperta il 27 ott 2020

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Java (9070 star) (1911 fork)batch import
help wantedproposal

Descrizione

The constructors for RetryableException were updated in #1039 to require the original Request object. In some cases the Request may contain sensitive information and never be used from the RetryableException, so it would be nice to have an option to create one without the Request to limit surface area.

Additionally, FeignException already exposes a hasRequest() method, so clients would be able to check whether RetryableException has a Request before attempting to access it.

I'd be more than happy to open a PR if this sounds like a reasonable use case. Thanks!

Guida contributor

Tech stack
java
Dominio
backendapi
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaFeign library
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Examine the RetryableException class in the source code to understand current constructors. Review the changes from PR #1039 that made Request required. Consider adding a new constructor that does not take Request, or making Request optional. Also check FeignException's hasRequest() method to ensure consistency. Create a PR with the changes and update tests accordingly.