Microsoft/vscode

Undo stacks are not granular enough for Korean

Open

#229.647 aperta il 25 set 2024

Vedi su GitHub
 (3 commenti) (2 reazioni) (2 assegnatari)TypeScript (10.221 fork)batch import
editor-input-IMEfeature-requesthelp wantedundo-redo

Metriche repository

Star
 (74.848 star)
Metriche merge PR
 (Merge medio 11h 43m) (1000 PR mergiate in 30 g)

Descrizione

Testing #229383

Right now, typing a sentence in Korean and pressing undo will remove the entire line. I confirmed with a native Korean speaker that the ideal behavior for undo is to remove the last consonant/vowel (each character is made up of 2-4 consonants/vowels). This might be difficult to do depending on how EditContext words, but a little less better but much better than deleting the whole line is to delete the last fully formed character.

Image

Note that this is not a regression, but it's a pretty bad existing great experience.

Guida contributor