Microsoft/vscode
Vedi su GitHuberrors thrown by openerService.resolveExternalUri not surfaced to MainThreadWindow.$asExternalUri in VS Code Web
Open
#162.770 aperta il 5 ott 2022
bughelp wantedopener
Metriche repository
- Star
- (74.848 star)
- Metriche merge PR
- (Merge medio 11h 43m) (1000 PR mergiate in 30 g)
Descrizione
- VS Code Version: 1.72.1 (
main) - OS Version: N/A
- Browser: Chrome
Steps to Reproduce:
git clone https://github.com/microsoft/vscode.git- run VS Code Web locally
- install any extension that uses
asExternalUri(i.e. this one) - run command "Hello World"
- Open Browser Console
Expected
Should log error thrown 'Could not resolve external URI: ' + resource.toString()
Actual Nothing
Notes
I believe this happens because there is no try/catch block here:
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/api/browser/mainThreadWindow.ts#L63
When you add a try/catch block there like so:
try {
const result = await this.openerService.resolveExternalUri(URI.revive(uriComponents), options);
return result.resolved;
} catch (e) {
console.error('something wrong', e);
}
const result = await this.openerService.resolveExternalUri(URI.revive(uriComponents), options);
return result.resolved;
Then it logs the thrown error
Screenshot
Would you accept a PR to fix this?