Microsoft/calculator

Enable code analysis on all projects and resolve warnings

Open

Aperta il 1 ott 2019

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)C++ (16.196 star) (2422 fork)batch import
Pri: 2approvedbuildcodebase qualityhelp wanted

Descrizione

Visual Studio's code analysis tools can help find issues in our C++ code. Eventually, it would be great to have these tools running in all of our builds and to fix all the warnings they generate.

See #689 for an example of how to enable the tools during the build. We'll enable code analysis only in the "Release" configuration to avoid slowing down Debug builds.

To see which warnings still need to be fixed, check a recent build from the master branch.

It would be best to submit fixes for unrelated warnings as separate PRs. I'll close out this issue when 1) all C++ projects are building with code analysis rules on and 2) all the warnings generated by those tools are fixed or silenced.

Guida contributor

Tech stack
cpp
Dominio
toolingbuild systemci cd
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
over 1 week
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
C++ basicsVisual Studio build configuration
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Review issue #689 for an example of enabling code analysis during build. Examine the Release configuration in project files. Check the Azure DevOps build link to see current warnings. Plan to fix warnings in separate PRs as suggested.