Microsoft/TypeScript

Private/protected properties on siblings in union types

Open

#9974 aperta il 27 lug 2016

Vedi su GitHub
 (3 commenti) (3 reazioni) (0 assegnatari)TypeScript (6726 fork)batch import
Domain: Error MessagesHelp WantedSuggestion

Metriche repository

Star
 (48.455 star)
Metriche merge PR
 (Merge medio 6g 17h) (9 PR mergiate in 30 g)

Descrizione

TypeScript Version: 1.8.9

Code

class Example {
    protected width = 0;
    constructor(sibling: Example | HTMLCanvasElement) {
        console.log(sibling.width);
    }
}

Expected behavior: No errors.

Actual behavior: Error: Property 'width' does not exist on type 'Example | HTMLCanvasElement'. Line 4, column 31

The reason this error occurs is that the width property is protected on Example but public on HTMLCanvasElement. However, the error is confusing for two reasons:

  1. The width property is available on both component properties in this situation. If the sibling parameter had a type of either Example or HTMLCanvasElement, the code would compile.
  2. The error message doesn't explain why the property does not exist on the type. Understanding the error requires the knowledge that properties are only available on union types if they have the same privacy level, even if those properties would be accessible in the component types in the active context.

I am not sure if there are situations in which the desired behavior is a compilation error when accessing a potentially protected property on a union type if that property is accessible on all component types. I can't think of any, and so I think the ideal situation would be that the compiler does not throw an error here. However, I think it would be an adequate solution to improve the error message.

(I apologize if this has been reported/discussed before. I searched but couldn't find anything exactly along these lines.)

Guida contributor