Microsoft/TypeScript

Typescript - inlay hints for nested labeled tuples

Open

#57.088 aperta il 18 gen 2024

Vedi su GitHub
 (0 commenti) (1 reazione) (0 assegnatari)TypeScript (6726 fork)batch import
BugDomain: LS: Inlay HintsHelp Wanted

Metriche repository

Star
 (48.455 star)
Metriche merge PR
 (Merge medio 6g 17h) (9 PR mergiate in 30 g)

Descrizione

Type: Feature Request

The inlay hints for an array of labeled tuples are forgotten.

Troubleshooting steps:

  • Ensured Typescript is fully up-to-date.
  • Enabled all inlay hints in vsCode settings.

When a type is described as tuple with labels, you can use the ...args: ThatTupleType and when calling the function, the parameters retain the labels. This is working just fine.

However, when the argument is more complex, and there are nested labeled tuples within the type, the inlay hint information is lost (although the type information is still there; TypeScript still knows that the labels are on the array).

The expectation is that if I pass an array of tuples to an argument or type that expects the tuples to adhere to rules, and the type has labels, that the inlay hints should show those nested labels in the appropriate place.

The below example will showcase the issue I'm referring to, when it's run in vsCode with all inlay hints enabled:

type ArmorValueSet = [number, number, number, number, number, number];
type ArmorValueRange = [minVals: ArmorValueSet, maxVals: ArmorValueSet];

const parseArmor = (
    armorValues: ArmorValueRange[]
) => {
    console.log(armorValues);
};

parseArmor([
    [[6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]],
    [[6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]],
    [[6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]],
    [[6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]],
    [[6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]],
]);

const test = (...args: ArmorValueRange) => {
    console.log(...args);
}

test([6, 21, 36, 56, 81, 140], [20, 35, 55, 80, 110, 180]);

On line 22, minVals and maxVals are shown correctly. However, from lines 11-15, there are no inlay hints for these tuple labels. The expectation is that each of these lines should look the same as line 22 in terms of the inlay hints that are shown.

Here is a screenshot of what my vsCode editor looks like with this code present:

image

VS Code version: Code 1.85.1 (0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2, 2023-12-13T09:49:37.021Z) OS version: Windows_NT x64 10.0.19045 Modes:

Guida contributor