Microsoft/TypeScript

[type bug] fontfaces property is missing from loadingdone event object

Aperta

#51.885 aperta il 14 dic 2022

 (0 commenti) (0 reazioni) (0 assegnatari)TypeScript (13.395 fork)batch import
BugDomain: lib.d.tsHelp Wanted

Metriche repository

Star
 (108.860 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Configuration Check

My compilation target is ES2015 and my lib is ES2022 & `DOM.

Missing / Incorrect Definition

Request to replace the event type of onloadingdone handler from Event to FontFaceSetLoadEvent, which has been defined in the same module.

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5530

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5548-L5550

Sample Code

interface FontFaceSet extends EventTarget {
-    onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;
+    onloadingdone: ((this: FontFaceSet, ev: FontFaceSetLoadEvent) => any) | null;
}

Documentation Link

https://w3c.github.io/csswg-drafts/css-font-loading/#FontFaceSet-events

Guida contributor