Microsoft/TypeScript

Add diff chunk header lines to Git

Open

#36.185 aperta il 14 gen 2020

Vedi su GitHub
 (4 commenti) (8 reazioni) (0 assegnatari)TypeScript (6726 fork)batch import
Community ToolingExperience EnhancementHelp WantedSuggestion

Metriche repository

Star
 (48.455 star)
Metriche merge PR
 (Merge medio 6g 17h) (9 PR mergiate in 30 g)

Descrizione

Search Terms

userdiff xfuncname

Suggestion

Please add regular expressions to https://github.com/git/git/blob/master/userdiff.c such that TypeScript constructs can be identified in a predictable manner by the Git diff algorithm.

Use Cases

When I do a git diff or git add -p that includes TypeScript code, it's nice to see the function and/or class names of the changed lines I am looking at.

Examples

  • git diff -- *.ts
  • git add -p -- *.ts

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
    • Particularly "Provide a structuring mechanism for larger pieces of code."

Guida contributor