Microsoft/TypeScript

commonjs export binding produces invalid code for increment/decrement in PrefixUnaryExpression

Open

#35.879 aperta il 27 dic 2019

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)TypeScript (6726 fork)batch import
BugDomain: JS EmitHelp Wanted

Metriche repository

Star
 (48.455 star)
Metriche merge PR
 (Merge medio 6g 17h) (9 PR mergiate in 30 g)

Descrizione

TypeScript Version: 3.7.2

Search Terms: export increment decrement syntax error

Code

// @module: commonjs
let foo = 1;
export { foo };
while (!--foo) { }

Expected behavior:

while (!(exports.foo = --foo)) { }

Actual behavior:

Because the module-transform uses onSubstituteNode, it doesn't use the auto-parenthesizing that's done by the factory API.

while (!exports.foo = --foo) { } // SyntaxError: `!exports.foo` is no valid assignment target

Playground Link: https://www.typescriptlang.org/play/?target=99&module=1&ssl=3&ssc=19&pln=1&pc=1#code/DYUwLgBAZg9jEF4IEYDcAoEAPADjATpAN7RwQC+GA7gBYCWoEAFAIQC0bsMAlBCeUA

Related Issues: #33044

Guida contributor