Microsoft/TypeScript

simply logic predicate code fix or suggestion

Open

#25.175 aperta il 23 giu 2018

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)TypeScript (6726 fork)batch import
Domain: LS: RefactoringsHelp WantedSuggestion

Metriche repository

Star
 (48.455 star)
Metriche merge PR
 (Merge medio 6g 17h) (9 PR mergiate in 30 g)

Descrizione

Search Terms

logic, predicate, quickfix

Suggestion

provide a code fix or refactor to simply logic predicate

Use Cases

simply some complexity logic predicate is hard and always get a break change, hope have a code fix to simply that like the jetbrain idea

Examples


if (! a && !b || !a && !c) {
    // something
}

fix to:

if (!(a && (b || c))) {
    // something
}

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript / JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. new expression-level syntax)

Guida contributor