ManimCommunity/manim

Add tuple key support in `GenericGraph.__getitem__()`

Chiusa

#3798 aperta il 9 giu 2024

 (2 commenti) (0 reazioni) (0 assegnatari)Python (1378 fork)batch import
good first issuenew feature

Metriche repository

Star
 (17.820 stelle)
Metriche merge PR
 (Merge medio 90g 10h) (31 PR mergiate in 30 g)

Descrizione

Description of proposed feature

vertices = [1, 2, 3, 4]
edges = [(1, 2), (2, 3), (3, 4), (1, 3), (1, 4)]
g = Graph(vertices, edges)
assert isinstance(g[1], Dot)  # This is OK
assert isinstance(g[(1, 2)], Line)  # But this will raise a KeyError

imo This is confusing. Why not add a support for edge mapping?

How can the new feature be used?

Every time people want to get or set a edge, just write g[(1, 2)] instead of g.edges[(1, 2)].

Guida contributor