VMobject inaccurately attributes width/height attrs to its bézier control points · ManimCommunity/manim#3619

(0 commenti) (0 reazioni) (0 assegnatari)Python (1378 fork)batch import

good first issueissue:bug

Metriche repository

Star: (17.820 star)
Metriche merge PR: (Merge medio 11g 17h) (4 PR mergiate in 30 g)

Descrizione

Description of bug / unexpected behavior

The VMobject width/height attributes are calculated using the points array which is actually the control points for the quadratic bézier curves. This is not very intuitive behavior for end-users.

Expected behavior

The VMobject width/height attributes should indicate the width/height of the physical curve, respectively.

How to reproduce the issue

class TestFail(Scene):
  def construct(self):
    c = Circle().scale(3)
    c.rotate(30*DEGREES)
    radius = c.width / 2
    l = Line().set_length(radius * 2).move_to(c)

    self.add(c, l)

Additional media files

https://discord.com/channels/581738731934056449/976376734935048223/1207665909871677500

Additional comments

Possibly related to this issue: #3344 This may be helpful for anyone fixing this issue in the future: https://stackoverflow.com/questions/2587751/an-algorithm-to-find-bounding-box-of-closed-bezier-curves

Guida contributor

Direzione di ricerca: Implementare un algoritmo per il bounding box delle curve di Bézier per calcolare la larghezza e l'altezza effettive della curva, sostituendo l'attuale metodo che utilizza i punti di controllo.
Tech stack: python
Dominio: backend
Tipo issue: Bug
Difficoltà: 3
Tempo stimato: Mezza giornata
Stato attività: Nuova
Chiarezza: Chiara
Prerequisiti: PythonGit
Adatta ai principianti: 60