LAION-AI/Open-Assistant

Handle edge case search queries better

Open

Aperta il 29 mag 2023

Vedi su GitHub
 (4 commenti) (0 reazioni) (1 assegnatario)Python (37.363 star) (3263 fork)batch import
backendgood first issue

Descrizione

We should do some preprocessing of search_query here to prevent errors in edge cases, e.g. where the query ends with an operator like & or |.

Words separated by only a space and no operator also have no effect currently, we could modify these such that & is inserted automatically.

List of valid operations I am aware of:

&
|
<->
!

The syntax also allows combinations like &! and groupings via parantheses.

https://github.com/LAION-AI/Open-Assistant/blob/main/backend/oasst_backend/prompt_repository.py#L1023

Guida contributor

Tech stack
python
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Python basicsstring manipulationunderstanding of search operators
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
35
Direzione di ricerca
Examine the function at backend/oasst backend/prompt repository.py line 1023 to understand current search query handling. Identify the parsing logic for operators (&, |, < >, !) and how the query is processed. Consider edge cases like trailing operators and missing operators between words. The comments may contain additional discussion about desired behavior. Implement preprocessing to sanitize the query and insert '&' where appropriate.