Knockout-Contrib/Knockout-Validation

validation may not work when relying only on parseInputAttributes

Open

#520 aperta il 24 gen 2015

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (394 fork)batch import
bughelp wanted

Metriche repository

Star
 (1024 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

When parseInputAttributes: true and the observable is not validatable the input does not get a validation message inserted, nor the validation class validationElement.

The problem is in the validationCore binding as it asynchronously executes parseInputValidationAttributes. The later method will make the observable validatable if it matches some criteria (eg. input type is number/email, has a required attribute etc.)

Solutions:

  • execute parseInputValidationAttributes synchronously - this adds some overhead when bindings are applied.
  • duplicate code in the validationCore binding to ensure config.insertMessages and config.decorateInputElement are applied if the observable becomes validatable.

I've created a fiddle for this - it has both the solutions and some intructions on how to fix it. The interesting code starts at line 1016 in the JavaScript panel of JSFiddle.

http://jsfiddle.net/3594jm1o/

Any thoughts?

Guida contributor