JuliaPluto/Pluto.jl

Switch to @msgpack/msgpack-javascript

Open

Aperta il 25 nov 2022

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)Julia (5295 star) (329 fork)batch import
enhancementfrontendgood first issueperformance

Descrizione

Right now we are using https://github.com/kawanet/msgpack-lite for the JS side of our MsgPack protocol, or actually, my fork https://github.com/fonsp/msgpack-lite/commit/699001171edfc1e990b14085917f869badfa4d5b where i directly edited the .min.js bundle to become an ES6 file 😅

It's working great, and I think it is quite fast.

We could switch to https://github.com/msgpack/msgpack-javascript , which is being actively developed, and more modern: it is written for ES6.

Guida contributor

Tech stack
javascript
Dominio
frontend
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScriptmsgpack liteES6 modules
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
The issue proposes switching from msgpack lite to @msgpack/msgpack javascript. First, identify all files that import or use msgpack lite, likely in the JavaScript bundle (e.g., in the frontend code). Then, compare the APIs of both libraries and replace usage accordingly. Ensure that the new library can be loaded as an ES6 module. Finally, run existing tests to verify the changes don't break functionality.