JanusGraph/janusgraph

Rollback documentation and code inconsistency

Open

#1077 aperta il 21 mag 2018

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Java (1137 fork)batch import
Hacktoberfestarea/docshelp wanted

Metriche repository

Star
 (4985 star)
Metriche merge PR
 (Merge medio 3g 18h) (12 PR mergiate in 30 g)

Descrizione

There is a sentence in the transactions' documentation:

If a commit() transactions fails, it should be terminated manually with rollback() after catching the failure.

And there is a code of commit() implementation:

try {
    if (this.hasModifications()) {
        this.graph.commit(this.addedRelations.getAll(), this.deletedRelations.values(), this);
    } else {
        this.txHandle.commit();
    }

    success = true;
} catch (Exception var9) {
    try {
        this.txHandle.rollback();
    } catch (BackendException var8) {
        throw new JanusGraphException("Could not rollback after a failed commit", var9);
    }

    throw new JanusGraphException("Could not commit transaction due to exception during persistence", var9);
}

As I see here, the rollback() is called if commit() is failed. I think that the documentation should say: If a commit() transactions fails, it will be terminated automatically with rollback() or something like that. Maybe some clarification should be put there.

Guida contributor