IntersectMBO/plutus

The evaluate-builtins optimization isn't conservative

Open

Aperta il 3 giu 2024

Vedi su GitHub
 (1 commento) (1 reazione) (0 assegnatari)Haskell (1637 star) (511 fork)batch import
Good first issueInternalPlutus IRbugoptimizationstatus: triagedtech debt

Descrizione

PlutusIR.Transform.EvaluateBuiltins turns ifThenElse True x y into x. That is not conservative: if y throws then the former term will throw and the latter one won't. So this is a bug that needs to be fixed. It wasn't discussed in the original PR.

More importantly, this looks like something that the proper property testing should catch. Look like a perfect opportunity for the PIR generators to show their power. So it'd be best to first write a failing property, then fix the bug.

Guida contributor

Tech stack
Nessuno
Dominio
backendtesting
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
4
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
3-5 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Plutus IR basicsProperty testingHaskell
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Examine the transformation in PlutusIR.Transform.EvaluateBuiltins that reduces ifThenElse with a constant boolean. Understand the original PR #5269 for context. Then design a property test using the PIR generators that checks that the transformation preserves semantics even when branches may throw. After a failing test is produced, fix the transformation to be conservative.