GoogleContainerTools/skaffold

Helm 2 rebuild on requirements.lock change

Aperta

#6943 aperta il 6 dic 2021

 (1 commento) (0 reazioni) (0 assegnatari)Go (1416 fork)batch import
area/deploydeploy/helmhelp wantedkind/feature-requestpriority/p2

Metriche repository

Star
 (12.822 stelle)
Metriche merge PR
 (Merge medio 3g 6h) (16 PR mergiate in 30 g)

Descrizione

On Skaffold v1.35.0, when a Helm 2 deploy is used, as soon as the dependency's requirements.lock file is added or changes, a rebuild is launched. Seems like #4181 was aimed at fixing this but somehow this only prevents the rebuild for the tmpcharts folder and its content, not the requirements.lock file.

Expected behavior

No rebuild on requirements.lock change

Actual behavior

Rebuild on requirements.lock change

Information

deploy:
  helm:
    releases:
    - name: project
      chartPath: helm
      artifactOverrides:
        backendImage: backend-image
        frontendImage: frontend-image
        databaseImage: database-image
      valuesFiles:
      - helm/values.yaml
      - helm/values.yaml.override
    flags:
      upgrade:
        - '--cleanup-on-fail'

Steps to reproduce the behavior

Use a Helm 2 chart having a dependency, on first install the project builds twice because of the creation of the requirements.lock file

Guida contributor