GoogleContainerTools/skaffold

Load images into minikube rather than replacing host's docker env

Aperta

#4654 aperta il 12 ago 2020

 (2 commenti) (1 reazione) (0 assegnatari)Go (1416 fork)batch import
area/buildhelp wantedkind/feature-requestplatform/minikubepriority/p2

Metriche repository

Star
 (12.822 stelle)
Metriche merge PR
 (Merge medio 3g 6h) (16 PR mergiate in 30 g)

Descrizione

currently in skaffold, if we detect a user has minikube as their active kubecontext, we run a minikube docker-env so that docker commands on the host machine build to minikube's docker daemon. this can cause issues if we're only trying to run a skaffold build while minikube is stopped - something that should be possible, but skaffold can't get around because it only knows to try and use minikube's docker daemon.

instead, we could use minikube cache add on images that are built locally, and do this on push, so builds will still work even when minikube's docker daemon is not accessible.

https://minikube.sigs.k8s.io/docs/handbook/pushing

Guida contributor