GoogleChromeLabs/quicklink

Do not prefetch links with `download` attribute

Open

Aperta il 15 mag 2020

Vedi su GitHub
 (1 commento) (1 reazione) (0 assegnatari)JavaScript (10.861 star) (431 fork)batch import
enhancementgood first issue

Descrizione

Is your feature request related to a problem? Please describe. Currently all links are prefetched including ones intended for downloadable assets. Since these links could point to large payloads (imagine multi megabyte PDFs or zip archives) that's quite a waste of bandwidth.

I'd argue excluding links which have the download attribute would be a sensible default.

Describe the solution you'd like

document.querySelectorAll('a:not([download])')

Thank you :)

Guida contributor

Tech stack
javascripthtml
Dominio
frontendperformance
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic JavaScriptDOM querySelectorsQuicklink library structure
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
Locate the code in quicklink's source where links are selected for prefetching, likely in the main prefetch function. Modify the query selector to exclude links with the `download` attribute. Ensure that the change is applied consistently across any link collection logic. No additional changes required beyond the selector update.