GoogleChromeLabs/quicklink

Consider adding `rootMargin` to the Intersection Observer

Open

Aperta il 10 dic 2018

Vedi su GitHub
 (13 commenti) (1 reazione) (0 assegnatari)JavaScript (10.861 star) (431 fork)batch import
enhancementgood first issuehelp wanted

Descrizione

Feedback from @surma:

I feel like by default you should add a rootMargin to the IO to trigger the load before something comes into the viewport.

So, rootMargin defaults to "0px 0px 0px 0px", meaning the intersection will be computed between the root element's unmodified bounds rectangle and the target's bounds. This change would be made to https://github.com/GoogleChromeLabs/quicklink/blob/master/src/index.mjs#L21

Guida contributor

Tech stack
javascript
Dominio
frontendperformance
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Intersection Observer APIJavaScriptquicklink library structure
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Review the conversation in the comments to understand desired behavior. The change needs to be made in src/index.mjs around line 21 where the Intersection Observer is instantiated. Ensure the rootMargin option is exposed and defaults to '0px 0px 0px 0px' if not provided. Test that prefetching triggers earlier with a non zero rootMargin.