GoogleChrome/lighthouse

Canonical URL audit mistakes invalid URLs for relative ones

Chiusa

#12.008 aperta il 26 gen 2021

Vedi su GitHubGuida contributor
 (7 commenti) (0 reazioni) (0 assegnatari)JavaScript (9278 fork)batch import
P3good first issue

Metriche repository

Star
 (27.768 stelle)
Metriche merge PR
 (Merge medio 18g 18h) (40 PR mergiate in 30 g)

Descrizione

Provide the steps to reproduce

  1. Run LH on https://output.jsbin.com/vulerujohi for just the canonical audit

What is the current behavior?

The audit fails with explanation Relative URL (https:// example.com)

What is the expected behavior?

The audit fails with explanation Invalid URL (https:// example.com)

Environment Information

  • Affected Channels: CLI, Node, DevTools
  • Lighthouse version: 7.0.1
  • Chrome version: 88.0.4324.96
  • Node.js version: 14.15.4
  • Operating System: macOS Mojave 10.14.6

Guida contributor

Direzione di ricerca
The issue is that the canonical URL audit incorrectly labels a URL with a space after 'https://' as 'Relative URL' instead of 'Invalid URL'. The fix is to locate the audit logic, likely in `lighthouse core/audits/seo/canonical.js` or similar, find the condition that outputs 'Relative URL', and change it to 'Invalid URL'. The test file for this audit should also be updated to reflect the corrected message.
Tech stack
javascriptnodejs
Dominio
frontendperformance
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
Meno di 1 ora
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Nuova
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
familiarity with Lighthousebasic JavaScript
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85