Glavin001/tslint-clean-code

Use Array.prototype.find() instead of .filter()[0]

Open

#56 aperta il 11 lug 2018

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)TypeScript (15 fork)github user discovery
good first issuehelp wanted

Metriche repository

Star
 (175 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

const items = [
  { id: 123 },
  { id: 456 }
  // ...
];
const selectedId = 456;
const selectedItem = items.filter(item => item.id === selectedIds)[0];

Should be:

// ...
const selectedItem = items.find(item => item.id === selectedIds);

Diff:

- const selectedItem = items.filter((item) => item.id === selectedIds)[0];
+ const selectedItem = items.find((item) => item.id === selectedIds);

Guida contributor