Flagsmith/flagsmith

Web Hook sends only one type of event (FLAG_UPDATED)

Open

Aperta il 9 gen 2021

Vedi su GitHub
 (7 commenti) (0 reazioni) (3 assegnatari)Python (3475 star) (264 fork)batch import
featuregood first issuetech-debt

Descrizione

Hi,

It is quite stupid to have one type for many events. Suggestion: On feature_segment update sends : FLAG_SEGMENT_UPDATED On feature_identity update sends : FLAG_IDENTITY_UPDATED on feature update sends : FLAG_FEATURE_UPDATED

Guida contributor

Tech stack
python
Dominio
backendapi
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic understanding of webhooksFamiliarity with PythonKnowledge of event driven patterns
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Examine the webhook sending logic in the backend codebase to locate where FLAG UPDATED events are dispatched. Identify the relevant files and functions handling event types. Review the comments on the issue for any additional context or suggested implementation details. Consider adding new event types like FLAG SEGMENT UPDATED, FLAG IDENTITY UPDATED, and FLAG FEATURE UPDATED, ensuring they are triggered at appropriate points.