incompressible_elasticity.jl example needs improvement
#369 aperta il 3 set 2021
Metriche repository
- Star
- (439 star)
- Metriche merge PR
- (Metriche PR in attesa)
Descrizione
I have been looking through the examples to get a better grasp at some of the basics of Ferrite, and while the incompressible elasticity example seem to demonstrate some strong features in mixed elements, the example lacks in clarity. The main issues seem to me to be:
- It isn't clear which PDE is being solved. Other examples actually explain what PDE they solve, but here there is only a refrence to "Cook's Membrane", which (despite being a named problem?) doesn't appear to be easy to look up. For instance it doesn't seem to have a Wikipedia entry. Maybe I'm just not smart enough, but I haven't been able to figure out what is being solved.
- Lines 133 and 134 appear to serve no function(?) https://github.com/Ferrite-FEM/Ferrite.jl/blob/75a4dab91a5f6ce4e239db68515732f1a1ac579e/docs/src/literate/incompressible_elasticity.jl#L133
- Unclear why lines 129 deserves its own loop and isn't just part of the subsequent loop over the same indices. https://github.com/Ferrite-FEM/Ferrite.jl/blob/75a4dab91a5f6ce4e239db68515732f1a1ac579e/docs/src/literate/incompressible_elasticity.jl#L129
There might be other things too, like in line 142 where j is iterated from 1 to n_basefunc_u instead of 1 to ì like every other instance. It would seem to me that the symmetrization process overwrites the extra entries anyway.
https://github.com/Ferrite-FEM/Ferrite.jl/blob/75a4dab91a5f6ce4e239db68515732f1a1ac579e/docs/src/literate/incompressible_elasticity.jl#L142