Famous/engine

GestureHandler doesn't fire "tap" for IE<11

Open

#323 aperta il 22 giu 2015

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (262 fork)batch import
bughelp wanted

Metriche repository

Star
 (1750 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

GestureHandler doesn't work for IE 10 and below. In famous-carousel, I've worked around it by calling this directly on the DOM element when IE is detected:

arrowEl.attachEvent("onclick", emitPageChange);

MS docs say addEventListener should work for IE 9+, but this doesn't seem to be the case. I could only get it to recognize clicks by calling attachEvent.

I loathe IE as much as anyone, but there are still a lot of systems running IE 9 & 10 and Famo.us does run on them for the most part. I looked through the engine code and from what I can tell, DOMElement.prototype.on() might be the place to modify. Would something like this be better placed under polyfills, if the Famo.us team finds it acceptable?

Guida contributor