FEniCS/dolfinx

Using exception subtypes

Aperta

#2398 aperta il 7 ott 2022

 (2 commenti) (0 reazioni) (0 assegnatari)C++ (255 fork)auto 404
enhancementgood first issuehousekeeping

Metriche repository

Star
 (1158 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

SonarCloud complains about our exception throwing, and I think it makes sense:

If you throw a general exception type, such as std::exception, std::logic_error or std::runtime_error, it forces consumers to catch all exceptions, including unknown exceptions they don’t necessarily know how to handle.

Instead, either throw a subtype that already exists ( for example in ), or create your own type that derives from a standard one.

https://wiki.sei.cmu.edu/confluence/display/java/ERR07-J.+Do+not+throw+RuntimeException%2C+Exception%2C+or+Throwable

Guida contributor