Esri/arcgis-rest-js
`isItemSharedWithGroup` returns `undefined` instead of false.
Aperta
#665 aperta il 3 mar 2020
good first issuehelp wanted
Metriche repository
- Star
- (389 stelle)
- Metriche merge PR
- (Merge medio 11g 4h) (5 PR mergiate in 30 g)
Descrizione
The return statement in isItemSharedWithGroup is incorrectly nested in an if block. This one flies under the radar because undefined is falsy, but it's a bug nonetheless.
function isItemSharedWithGroup(requestOptions) {
var searchOpts = {
q: "id: " + requestOptions.id + " AND group: " + requestOptions.groupId,
start: 1,
num: 10,
sortField: "title",
authentication: requestOptions.authentication,
httpMethod: "POST"
};
return Object(_items_search__WEBPACK_IMPORTED_MODULE_7__["searchItems"])(searchOpts).then(function (searchResponse) {
var result = false;
if (searchResponse.total > 0) {
result = searchResponse.results.some(function (itm) {
return itm.id === requestOptions.id;
});
return result; // SHOULD BE OUTSIDE THE IF BLOCK
}
});
}